[
https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873566
]
ASF GitHub Bot logged work on ARTEMIS-4372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/23 15:10
Start Date: 28/Jul/23 15:10
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1277680335
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/DestAbstract.java:
##########
@@ -21,29 +21,29 @@
import javax.jms.JMSException;
import javax.jms.Session;
-import com.github.rvesse.airline.annotations.Option;
import org.apache.activemq.artemis.cli.factory.serialize.MessageSerializer;
import org.apache.activemq.artemis.cli.factory.serialize.XMLMessageSerializer;
import org.apache.activemq.artemis.jms.client.ActiveMQDestination;
+import picocli.CommandLine.Option;
public class DestAbstract extends ConnectionAbstract {
- @Option(name = "--destination", description = "Destination to be used. It
can be prefixed with queue:// or topic:// and can be an FQQN in the form of
<address>::<queue>. Default: queue://TEST.")
+ @Option(names = "--destination", description = "Destination to be used. It
can be prefixed with queue:// or topic:// and can be an FQQN in the form of
<address>::<queue>. Default: queue://TEST.")
String destination = "queue://TEST";
- @Option(name = "--message-count", description = "Number of messages to act
on. Default: 1000.")
+ @Option(names = "--message-count", description = "Number of messages to act
on. Default: 1000.")
int messageCount = 1000;
- @Option(name = "--sleep", description = "Time wait between each message.")
+ @Option(names = "--sleep", description = "Time wait between each message.")
int sleep = 0;
- @Option(name = "--txt-size", description = "Transaction batch size.")
+ @Option(names = {"--txt-size", "--tx-batch-size"}, description =
"Transaction batch size. (--txt-size is deprecated)")
Review Comment:
I'm using hidden now...
and I opened a PR and bug on pico to fix the auto-completion on the shell:
https://github.com/remkop/picocli/pull/2075
Issue Time Tracking
-------------------
Worklog Id: (was: 873566)
Time Spent: 4h 20m (was: 4h 10m)
> Move CLI framework to picocli and implement auto-complete
> ---------------------------------------------------------
>
> Key: ARTEMIS-4372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4372
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.31.0
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
