[
https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873599
]
ASF GitHub Bot logged work on ARTEMIS-4372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/23 19:33
Start Date: 28/Jul/23 19:33
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1278011424
##########
artemis-distribution/src/main/resources/bin/artemis:
##########
@@ -91,6 +91,9 @@ if $cygwin ; then
fi
exec "$JAVACMD" $JAVA_ARGS $ARTEMIS_CLUSTER_PROPS \
+ --add-opens java.base/java.lang=ALL-UNNAMED \
+ --add-opens java.base/java.io=ALL-UNNAMED \
+ --add-opens java.base/java.util=ALL-UNNAMED \
Review Comment:
@gnodet I"m adding jline3 into artemis, integrated with pico-CLI. This PR is
taking an example from the jline3 along with some examples I saw on pico-cli ..
and I had to include these with JDK-11, while these are not needed in 17.
I'm confused what I need to do to integrate this. can you help us here?
##########
artemis-distribution/src/main/resources/bin/artemis:
##########
@@ -91,6 +91,9 @@ if $cygwin ; then
fi
exec "$JAVACMD" $JAVA_ARGS $ARTEMIS_CLUSTER_PROPS \
+ --add-opens java.base/java.lang=ALL-UNNAMED \
+ --add-opens java.base/java.io=ALL-UNNAMED \
+ --add-opens java.base/java.util=ALL-UNNAMED \
Review Comment:
hmmmmmmm... I don't need these with JDK17.
@gnodet it would be so nice to get your help here? :)
Issue Time Tracking
-------------------
Worklog Id: (was: 873599)
Time Spent: 5h (was: 4h 50m)
> Move CLI framework to picocli and implement auto-complete
> ---------------------------------------------------------
>
> Key: ARTEMIS-4372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4372
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.31.0
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
