[
https://issues.apache.org/jira/browse/ARTEMIS-4436?focusedWorklogId=881955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881955
]
ASF GitHub Bot logged work on ARTEMIS-4436:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/23 17:04
Start Date: 26/Sep/23 17:04
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4628:
URL: https://github.com/apache/activemq-artemis/pull/4628#discussion_r1337525083
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##########
@@ -1593,4 +1593,10 @@ void
noQueueIdDefined(org.apache.activemq.artemis.api.core.Message message,
@LogMessage(id = 224130, value = "The {} value {} will override the {}
value {} since both are set.", level = LogMessage.Level.INFO)
void configParamOverride(String overridingParam, Object
overridingParamValue, String overriddenParam, Object overriddenParamValue);
+
+ @LogMessage(id = 224131, value = "Connection closed with failedOver={}",
level = LogMessage.Level.INFO)
+ void bridgeConnectionClosed(Boolean failedOver);
+
+ @LogMessage(id = 224132, value = "There is a possible split brain on nodeID
{} closing. Topology update ignored", level = LogMessage.Level.INFO)
+ void possibleSplitBrainAfterClosing(String nodeID);
Review Comment:
I didn't even see this message amongst the original changes. A "possible
split brain" situation seems like its always a warning to me?
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java:
##########
@@ -554,9 +554,13 @@ public boolean updateMember(long uniqueEventID, String
nodeId, TopologyMemberImp
* @return
*/
@Override
- public boolean removeMember(final long uniqueEventID, final String nodeId) {
+ public boolean removeMember(final long uniqueEventID, final String nodeId,
final boolean disconnect) {
if (nodeId.equals(nodeManager.getNodeId().toString())) {
- ActiveMQServerLogger.LOGGER.possibleSplitBrain(nodeId);
+ if ( disconnect) {
Review Comment:
Inconsistent spacing before/after (slightly surprised Checkstyle isnt
configured to reject this given all the other things it barfs on hehe).
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java:
##########
@@ -198,9 +199,12 @@ public void fail(final ActiveMQException me, String
scaleDownTargetNodeID) {
destroyed = true;
}
- if (!(me instanceof ActiveMQRemoteDisconnectException) && !(me
instanceof ActiveMQRoutingException)) {
+ if (!(me instanceof ActiveMQRemoteDisconnectException) && !(me
instanceof ActiveMQRoutingException) && !(me instanceof
ActiveMQDisconnectedException)) {
ActiveMQClientLogger.LOGGER.connectionFailureDetected(transportConnection.getRemoteAddress(),
me.getMessage(), me.getType());
}
+ if (me instanceof ActiveMQDisconnectedException) {
Review Comment:
Feels like else-if would be more appropriate here since this is an either-or
situation, emit one message or the other depending on situation.
Issue Time Tracking
-------------------
Worklog Id: (was: 881955)
Time Spent: 1h 40m (was: 1.5h)
> Artemis is logging warnings during clean shutdown of server in cluster
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-4436
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4436
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 2.30.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> If a node from a cluster shutdowns cleanly this shouldn't create WARN
> messages in the logs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
