[
https://issues.apache.org/jira/browse/ARTEMIS-4436?focusedWorklogId=882352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882352
]
ASF GitHub Bot logged work on ARTEMIS-4436:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/23 09:44
Start Date: 28/Sep/23 09:44
Worklog Time Spent: 10m
Work Description: ehsavoie commented on code in PR #4628:
URL: https://github.com/apache/activemq-artemis/pull/4628#discussion_r1339837647
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionImpl.java:
##########
@@ -554,10 +554,12 @@ public boolean updateMember(long uniqueEventID, String
nodeId, TopologyMemberImp
* @return
*/
@Override
- public boolean removeMember(final long uniqueEventID, final String nodeId) {
+ public boolean removeMember(final long uniqueEventID, final String nodeId,
final boolean disconnect) {
if (nodeId.equals(nodeManager.getNodeId().toString())) {
- ActiveMQServerLogger.LOGGER.possibleSplitBrain(nodeId);
- return false;
+ if (!disconnect) {
+ ActiveMQServerLogger.LOGGER.possibleSplitBrain(nodeId);
+ return false;
+ }
Review Comment:
yes maybe I should leave it to return false.
Leaving it to WARN will mean having a warning when a node leaves which seems
strange to me
Issue Time Tracking
-------------------
Worklog Id: (was: 882352)
Time Spent: 2h 20m (was: 2h 10m)
> Artemis is logging warnings during clean shutdown of server in cluster
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-4436
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4436
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 2.30.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> If a node from a cluster shutdowns cleanly this shouldn't create WARN
> messages in the logs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
