[
https://issues.apache.org/jira/browse/ARTEMIS-4443?focusedWorklogId=882335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882335
]
ASF GitHub Bot logged work on ARTEMIS-4443:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/23 08:30
Start Date: 28/Sep/23 08:30
Worklog Time Spent: 10m
Work Description: brusdev commented on PR #4634:
URL:
https://github.com/apache/activemq-artemis/pull/4634#issuecomment-1738706849
@gtully this is a cool improvement!
What about using an annotation to avoid the suffix `.class` and the default
getName method?
```
public @interface BrokerProperty {
enum NameType {
PROPERTY,
CLASS
}
public NameType itemName() default NameType.PROPERTY;
}
@Override
@BrokerProperty(itemName = BrokerProperty.NameType.CLASS)
public List<ActiveMQServerBasePlugin> getBrokerPlugins() {
...
```
Issue Time Tracking
-------------------
Worklog Id: (was: 882335)
Time Spent: 40m (was: 0.5h)
> properties config - support broker plugin - logging broker plugin
> -----------------------------------------------------------------
>
> Key: ARTEMIS-4443
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4443
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker, Configuration
> Affects Versions: 2.31.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Fix For: 2.32.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> broker plugins require a way to add a new instance of a class to a collection
> via broker properties. Using the class name as the key can work nicely.
> In addition, the registration and configuration of broker plugins needs to be
> separated, currently they are handled in a single method call.
> {code}
> brokerPlugins.\"org.apache.activemq.artemis.core.server.plugin.impl.LoggingActiveMQServerPlugin.class\".init=LOG_ALL_EVENTS=false
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
