[ 
https://issues.apache.org/jira/browse/ARTEMIS-4443?focusedWorklogId=882434&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882434
 ]

ASF GitHub Bot logged work on ARTEMIS-4443:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Sep/23 13:36
            Start Date: 28/Sep/23 13:36
    Worklog Time Spent: 10m 
      Work Description: gtully commented on PR #4634:
URL: 
https://github.com/apache/activemq-artemis/pull/4634#issuecomment-1739204841

   Thanks Dom, not yet sure of the annotation gives any value, but I see that 
we never reuse the configuration instance on reload, and it may be that a 
plugin is never referenced for configuration purposes, meaning a name attribute 
won't be necessary, everything needs to go through init which is a single line. 
That can simplify the use case a lot




Issue Time Tracking
-------------------

    Worklog Id:     (was: 882434)
    Time Spent: 50m  (was: 40m)

> properties config - support broker plugin - logging broker plugin
> -----------------------------------------------------------------
>
>                 Key: ARTEMIS-4443
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4443
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker, Configuration
>    Affects Versions: 2.31.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Major
>             Fix For: 2.32.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> broker plugins require a way to add a new instance of a class to a collection 
> via broker properties. Using the class name as the key can work nicely.
> In addition, the registration and configuration of broker plugins needs to be 
> separated, currently they are handled in a single method call.
> {code}    
> brokerPlugins.\"org.apache.activemq.artemis.core.server.plugin.impl.LoggingActiveMQServerPlugin.class\".init=LOG_ALL_EVENTS=false
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to