[ 
https://issues.apache.org/jira/browse/OPENWIRE-69?focusedWorklogId=894388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894388
 ]

ASF GitHub Bot logged work on OPENWIRE-69:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Dec/23 21:44
            Start Date: 06/Dec/23 21:44
    Worklog Time Spent: 10m 
      Work Description: cshannon commented on PR #4:
URL: https://github.com/apache/activemq-openwire/pull/4#issuecomment-1843739420

   So I am going to mark this as a draft for now as it works but I think I will 
update this to be smarter. Right now it just looks for unique sequences which 
is a good start but I think we should be smarter and just iterate over it after 
we have sorted the list and also verify that there are no gaps. We wouldn't 
want sequence ids of something like 1,2,4 we would only want to allow 1,2,3 so 
I can fix that tomorrow and push a new commit.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 894388)
    Time Spent: 20m  (was: 10m)

> Sequence ID for openwire properties is not correct in some types
> ----------------------------------------------------------------
>
>                 Key: OPENWIRE-69
>                 URL: https://issues.apache.org/jira/browse/OPENWIRE-69
>             Project: ActiveMQ OpenWire
>          Issue Type: Bug
>            Reporter: Timothy A. Bish
>            Assignee: Christopher L. Shannon
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartialCommand and ProducerAck seem to have identical sequence ID values for 
> the property annotations which should be fixed, and maybe checked by the 
> annotation processor since no two properties should have the same sequence.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to