[ 
https://issues.apache.org/jira/browse/OPENWIRE-69?focusedWorklogId=894505&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894505
 ]

ASF GitHub Bot logged work on OPENWIRE-69:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Dec/23 13:06
            Start Date: 07/Dec/23 13:06
    Worklog Time Spent: 10m 
      Work Description: cshannon commented on PR #4:
URL: https://github.com/apache/activemq-openwire/pull/4#issuecomment-1845312561

   @tabish121 - As i updated in my description, a lot more validatiion is now 
done. I am checking that sequences are positive, not contiguous and not 
duplicated. I also added a sanity check for the OpenWireType annotation to 
actually exist. As you noted a lot more validation like this probably needs ot 
be done elsewhere but this is a good start for this and more checks can be done 
in follow on issues.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 894505)
    Time Spent: 40m  (was: 0.5h)

> Sequence ID for openwire properties is not correct in some types
> ----------------------------------------------------------------
>
>                 Key: OPENWIRE-69
>                 URL: https://issues.apache.org/jira/browse/OPENWIRE-69
>             Project: ActiveMQ OpenWire
>          Issue Type: Bug
>            Reporter: Timothy A. Bish
>            Assignee: Christopher L. Shannon
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> PartialCommand and ProducerAck seem to have identical sequence ID values for 
> the property annotations which should be fixed, and maybe checked by the 
> annotation processor since no two properties should have the same sequence.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to