[
https://issues.apache.org/jira/browse/ARTEMIS-4544?focusedWorklogId=896349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-896349
]
ASF GitHub Bot logged work on ARTEMIS-4544:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/23 20:15
Start Date: 19/Dec/23 20:15
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4721:
URL: https://github.com/apache/activemq-artemis/pull/4721#discussion_r1431897080
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederation.java:
##########
@@ -239,7 +243,7 @@ public synchronized AMQPFederation
addQueueMatchPolicy(FederationReceiveFromQueu
* @throws ActiveMQException if an error occurs processing the added policy
*/
public synchronized AMQPFederation
addAddressMatchPolicy(FederationReceiveFromAddressPolicy addressPolicy) throws
ActiveMQException {
- final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy);
+ final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy,
server.getConfiguration().isLargeMessageSync());
Review Comment:
@tabish121 I don't see an alternative here. Federation has no access to the
SPI.
I could add the SPI, other stuff... but I need to add something.
Issue Time Tracking
-------------------
Worklog Id: (was: 896349)
Time Spent: 40m (was: 0.5h)
> Option to not sync large messages
> ---------------------------------
>
> Key: ARTEMIS-4544
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4544
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.32.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When writing large messages we always sync the large message before closing.
> We should have an option to bypass that and trust the OS on that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
