[
https://issues.apache.org/jira/browse/ARTEMIS-4544?focusedWorklogId=896350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-896350
]
ASF GitHub Bot logged work on ARTEMIS-4544:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/23 20:20
Start Date: 19/Dec/23 20:20
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4721:
URL: https://github.com/apache/activemq-artemis/pull/4721#discussion_r1431901284
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederation.java:
##########
@@ -239,7 +243,7 @@ public synchronized AMQPFederation
addQueueMatchPolicy(FederationReceiveFromQueu
* @throws ActiveMQException if an error occurs processing the added policy
*/
public synchronized AMQPFederation
addAddressMatchPolicy(FederationReceiveFromAddressPolicy addressPolicy) throws
ActiveMQException {
- final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy);
+ final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy,
server.getConfiguration().isLargeMessageSync());
Review Comment:
You don't need it, that's the issue, the places it is use all have access to
ProtonAbstractReceiver which can call, getSessionContext() on it and ask if
sync is needed
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederation.java:
##########
@@ -239,7 +243,7 @@ public synchronized AMQPFederation
addQueueMatchPolicy(FederationReceiveFromQueu
* @throws ActiveMQException if an error occurs processing the added policy
*/
public synchronized AMQPFederation
addAddressMatchPolicy(FederationReceiveFromAddressPolicy addressPolicy) throws
ActiveMQException {
- final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy);
+ final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy,
server.getConfiguration().isLargeMessageSync());
Review Comment:
You don't need it, that's the issue, the places it is used all have access
to ProtonAbstractReceiver which can call, getSessionContext() on it and ask if
sync is needed
Issue Time Tracking
-------------------
Worklog Id: (was: 896350)
Time Spent: 50m (was: 40m)
> Option to not sync large messages
> ---------------------------------
>
> Key: ARTEMIS-4544
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4544
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.32.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When writing large messages we always sync the large message before closing.
> We should have an option to bypass that and trust the OS on that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
