[
https://issues.apache.org/jira/browse/ARTEMIS-4552?focusedWorklogId=899352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899352
]
ASF GitHub Bot logged work on ARTEMIS-4552:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/24 10:40
Start Date: 12/Jan/24 10:40
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4729:
URL: https://github.com/apache/activemq-artemis/pull/4729#discussion_r1450218942
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/routing/ConnectionRouterConfiguration.java:
##########
@@ -26,8 +26,8 @@ public class ConnectionRouterConfiguration implements
Serializable {
private KeyType keyType = KeyType.SOURCE_IP;
private String keyFilter = null;
private String localTargetFilter = null;
- private CacheConfiguration cacheConfiguration = null;
- private PoolConfiguration poolConfiguration = null;
+ private CacheConfiguration cacheConfiguration = new
CacheConfiguration().setEnabled(false);
+ private PoolConfiguration poolConfiguration = new
PoolConfiguration().setEnabled(false);
Review Comment:
I had the same reaction as Tim to the original code but hadnt got to
thinking of an improvement.
In some ways this is definitely better, the code is a little more consistent
with itself and other previous code. In others its much the same as before; the
'enabled' bit can now be controlled in both configs rather than just one, but
there is still effectively 3 different/conflicting 'default' behaviours for it
between XML and broker-properties and both, which is confusing. But I dont
necessarily have an idea thats nicer to resolve that while there are actually 3
different ways of configuring things.
Issue Time Tracking
-------------------
Worklog Id: (was: 899352)
Time Spent: 50m (was: 40m)
> Configure all connection-router settings by using broker properties
> -------------------------------------------------------------------
>
> Key: ARTEMIS-4552
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4552
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Allow to configure all the connection-router settings by using the broker
> properties. The broker properties for the cache configuration cause a null
> pointer exception:
> {code}
> "connectionRouters.autoShard.cacheConfiguration.persisted=true"
> "connectionRouters.autoShard.cacheConfiguration.timeout=60000"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
