[
https://issues.apache.org/jira/browse/ARTEMIS-4552?focusedWorklogId=899440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899440
]
ASF GitHub Bot logged work on ARTEMIS-4552:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/24 15:34
Start Date: 12/Jan/24 15:34
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4729:
URL: https://github.com/apache/activemq-artemis/pull/4729#discussion_r1450611631
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/routing/ConnectionRouterConfiguration.java:
##########
@@ -26,8 +26,8 @@ public class ConnectionRouterConfiguration implements
Serializable {
private KeyType keyType = KeyType.SOURCE_IP;
private String keyFilter = null;
private String localTargetFilter = null;
- private CacheConfiguration cacheConfiguration = null;
- private PoolConfiguration poolConfiguration = null;
+ private CacheConfiguration cacheConfiguration = new
CacheConfiguration().setEnabled(false);
+ private PoolConfiguration poolConfiguration = new
PoolConfiguration().setEnabled(false);
Review Comment:
I'm happy enough that it is at least more obvious now that it is more
visible that it is consistently inconsistent between the various configuration
paths. Other than more documentation surrounding those inconsistencies I'm not
sure how we could fix that sadly.
Issue Time Tracking
-------------------
Worklog Id: (was: 899440)
Time Spent: 1h (was: 50m)
> Configure all connection-router settings by using broker properties
> -------------------------------------------------------------------
>
> Key: ARTEMIS-4552
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4552
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Allow to configure all the connection-router settings by using the broker
> properties. The broker properties for the cache configuration cause a null
> pointer exception:
> {code}
> "connectionRouters.autoShard.cacheConfiguration.persisted=true"
> "connectionRouters.autoShard.cacheConfiguration.timeout=60000"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
