[
https://issues.apache.org/jira/browse/ARTEMIS-4569?focusedWorklogId=900220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900220
]
ASF GitHub Bot logged work on ARTEMIS-4569:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/24 19:58
Start Date: 17/Jan/24 19:58
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4743:
URL: https://github.com/apache/activemq-artemis/pull/4743#discussion_r1456406319
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/runnables/RunnableList.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.runnables;
+
+import java.util.HashSet;
+import java.util.function.Consumer;
+
+public class RunnableList {
+
+ private final HashSet<AtomicRunnable> list = new HashSet<>();
+
+ public RunnableList() {
+ }
+
+ public synchronized void add(AtomicRunnable runnable) {
+ runnable.setAcceptedList(this);
+ list.add(runnable);
+ }
+
+ public int size() {
+ return list.size();
+ }
+
+ public synchronized void remove(AtomicRunnable runnable) {
+ list.remove(runnable);
+ }
+
+ public void afterRun(AtomicRunnable runnable) {
Review Comment:
@tabish121 I just thought it would be more descriptive to a dedicated
operation to be called after the execution.. Future extension points.. etc.
I will change it to call remove directly though. I will mark this as a
resolve when I push the commit.
Thanks a lot
Issue Time Tracking
-------------------
Worklog Id: (was: 900220)
Time Spent: 0.5h (was: 20m)
> Blocked Producers Memory Leaks
> ------------------------------
>
> Key: ARTEMIS-4569
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4569
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.31.2
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.32.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Say you have paging configured as blocking. And you keep opening and closing
> connections that will be blocked while producing.
> These Runnables will accumulate until the number of messages goes back to
> negative again.
> Also these are holding Connections and other server objects.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
