[
https://issues.apache.org/jira/browse/ARTEMIS-4569?focusedWorklogId=900224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900224
]
ASF GitHub Bot logged work on ARTEMIS-4569:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/24 20:06
Start Date: 17/Jan/24 20:06
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4743:
URL: https://github.com/apache/activemq-artemis/pull/4743#discussion_r1456415601
##########
tests/leak-tests/src/test/java/org/apache/activemq/artemis/tests/leak/ProducerBlockedLeakTest.java:
##########
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.leak;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+
+import java.lang.invoke.MethodHandles;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import io.github.checkleak.core.CheckLeak;
+import org.apache.activemq.artemis.api.core.ActiveMQException;
+import org.apache.activemq.artemis.api.core.QueueConfiguration;
+import org.apache.activemq.artemis.api.core.RoutingType;
+import org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.Queue;
+import org.apache.activemq.artemis.core.server.impl.AddressInfo;
+import org.apache.activemq.artemis.core.settings.impl.AddressFullMessagePolicy;
+import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
+import org.apache.activemq.artemis.logs.AssertionLoggerHandler;
+import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.apache.activemq.artemis.tests.util.CFUtil;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.Wait;
+import org.junit.Assert;
+import org.junit.Assume;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ProducerBlockedLeakTest extends ActiveMQTestBase {
+
+ private static final int OK = 100;
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ private static final String QUEUE_NAME = "TEST_BLOCKED_QUEUE";
+
+ ActiveMQServer server;
+
+ @BeforeClass
+ public static void beforeClass() throws Exception {
+ Assume.assumeTrue(CheckLeak.isLoaded());
+ }
+
+ @Override
+ @Before
+ public void setUp() throws Exception {
+ super.setUp();
+ server = createServer(true, createDefaultConfig(1, true));
+ server.getConfiguration().getAddressSettings().clear();
+ server.getConfiguration().getAddressSettings().put("#", new
AddressSettings().setAddressFullMessagePolicy(AddressFullMessagePolicy.BLOCK).setMaxSizeMessages(10));
+ server.start();
+ }
+
+ @Test
+ public void testOPENWIRE() throws Exception {
+ testBlocked("OPENWIRE");
+ }
+
+ @Test
+ public void testCORE() throws Exception {
+ testBlocked("CORE");
+ }
+
+ @Test
+ public void testAMQP() throws Exception {
+ testBlocked("AMQP");
+ }
+
+ private void testBlocked(String protocol) throws Exception {
+ testBody(protocol);
+ MemoryAssertions.basicMemoryAsserts(false);
+ Queue queue = server.locateQueue(QUEUE_NAME);
+ queue.deleteAllReferences();
+ MemoryAssertions.basicMemoryAsserts(true);
+ server.stop();
+ }
+
+ // separating the test into a sub-method just to allow removing local
references
+ // so they would be gone when basicMemoryAsserts is called
+ private void testBody(String protocol) throws Exception {
+ try (AssertionLoggerHandler loggerHandler = new
AssertionLoggerHandler()) {
+ AtomicInteger messagesSent = new AtomicInteger(0);
+
+ server.addAddressInfo(new
AddressInfo(QUEUE_NAME).addRoutingType(RoutingType.ANYCAST));
+ server.createQueue(new
QueueConfiguration(QUEUE_NAME).setAddress(QUEUE_NAME).setRoutingType(RoutingType.ANYCAST).setDurable(true));
+
+ // clients need to be disconnected while blocked. For that reason a
new VM is being spawned
+ Process process =
SpawnedVMSupport.spawnVM(ProducerBlockedLeakTest.class.getName(), protocol,
"10");
+
+ Wait.assertTrue(() -> loggerHandler.findText("AMQ222183"), 5000, 10);
//unblock
+
+ process.destroyForcibly();
+ Assert.assertTrue(process.waitFor(10, TimeUnit.SECONDS));
Review Comment:
Wrong comment here. It's actually blocked...
##########
tests/leak-tests/src/test/java/org/apache/activemq/artemis/tests/leak/ProducerBlockedLeakTest.java:
##########
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.leak;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+
+import java.lang.invoke.MethodHandles;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import io.github.checkleak.core.CheckLeak;
+import org.apache.activemq.artemis.api.core.ActiveMQException;
+import org.apache.activemq.artemis.api.core.QueueConfiguration;
+import org.apache.activemq.artemis.api.core.RoutingType;
+import org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.Queue;
+import org.apache.activemq.artemis.core.server.impl.AddressInfo;
+import org.apache.activemq.artemis.core.settings.impl.AddressFullMessagePolicy;
+import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
+import org.apache.activemq.artemis.logs.AssertionLoggerHandler;
+import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.apache.activemq.artemis.tests.util.CFUtil;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.Wait;
+import org.junit.Assert;
+import org.junit.Assume;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ProducerBlockedLeakTest extends ActiveMQTestBase {
+
+ private static final int OK = 100;
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ private static final String QUEUE_NAME = "TEST_BLOCKED_QUEUE";
+
+ ActiveMQServer server;
+
+ @BeforeClass
+ public static void beforeClass() throws Exception {
+ Assume.assumeTrue(CheckLeak.isLoaded());
+ }
+
+ @Override
+ @Before
+ public void setUp() throws Exception {
+ super.setUp();
+ server = createServer(true, createDefaultConfig(1, true));
+ server.getConfiguration().getAddressSettings().clear();
+ server.getConfiguration().getAddressSettings().put("#", new
AddressSettings().setAddressFullMessagePolicy(AddressFullMessagePolicy.BLOCK).setMaxSizeMessages(10));
+ server.start();
+ }
+
+ @Test
+ public void testOPENWIRE() throws Exception {
+ testBlocked("OPENWIRE");
+ }
+
+ @Test
+ public void testCORE() throws Exception {
+ testBlocked("CORE");
+ }
+
+ @Test
+ public void testAMQP() throws Exception {
+ testBlocked("AMQP");
+ }
+
+ private void testBlocked(String protocol) throws Exception {
+ testBody(protocol);
+ MemoryAssertions.basicMemoryAsserts(false);
+ Queue queue = server.locateQueue(QUEUE_NAME);
+ queue.deleteAllReferences();
+ MemoryAssertions.basicMemoryAsserts(true);
+ server.stop();
+ }
+
+ // separating the test into a sub-method just to allow removing local
references
+ // so they would be gone when basicMemoryAsserts is called
+ private void testBody(String protocol) throws Exception {
+ try (AssertionLoggerHandler loggerHandler = new
AssertionLoggerHandler()) {
+ AtomicInteger messagesSent = new AtomicInteger(0);
+
+ server.addAddressInfo(new
AddressInfo(QUEUE_NAME).addRoutingType(RoutingType.ANYCAST));
+ server.createQueue(new
QueueConfiguration(QUEUE_NAME).setAddress(QUEUE_NAME).setRoutingType(RoutingType.ANYCAST).setDurable(true));
+
+ // clients need to be disconnected while blocked. For that reason a
new VM is being spawned
+ Process process =
SpawnedVMSupport.spawnVM(ProducerBlockedLeakTest.class.getName(), protocol,
"10");
+
+ Wait.assertTrue(() -> loggerHandler.findText("AMQ222183"), 5000, 10);
//unblock
Review Comment:
wrong comment here.. it's blocked
Issue Time Tracking
-------------------
Worklog Id: (was: 900224)
Time Spent: 1h (was: 50m)
> Blocked Producers Memory Leaks
> ------------------------------
>
> Key: ARTEMIS-4569
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4569
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.31.2
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.32.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Say you have paging configured as blocking. And you keep opening and closing
> connections that will be blocked while producing.
> These Runnables will accumulate until the number of messages goes back to
> negative again.
> Also these are holding Connections and other server objects.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
