[ 
https://issues.apache.org/jira/browse/ARTEMIS-4527?focusedWorklogId=901524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901524
 ]

ASF GitHub Bot logged work on ARTEMIS-4527:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jan/24 19:18
            Start Date: 24/Jan/24 19:18
    Worklog Time Spent: 10m 
      Work Description: AntonRoskvist commented on code in PR #4705:
URL: https://github.com/apache/activemq-artemis/pull/4705#discussion_r1465431024


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java:
##########
@@ -278,7 +279,12 @@ private void setupNotificationConsumer() throws Exception {
                                                    
createPermissiveManagementNotificationToFilter() +
                                                    ")");
 
-         sessionConsumer.createQueue(new 
QueueConfiguration(notifQueueName).setAddress(managementNotificationAddress).setFilterString(filter).setDurable(false).setTemporary(true));
+         sessionConsumer.createQueue(new QueueConfiguration(notifQueueName)
+                                        
.setAddress(managementNotificationAddress)
+                                        .setFilterString(filter)
+                                        .setDurable(false)
+                                        .setTemporary(true)
+                                        
.setRoutingType(RoutingType.MULTICAST));

Review Comment:
   Semi related and making sure. I saw this issue presenting very consistently 
on a broker cluster in a TEST environment. Turn out they had configured 
default-routing-type = ANYCAST as an address setting and a match on "#" so that 
the notifications got load balanced between brokers, sort of mimicking the 
issue I'm going after with this PR.
   
   I figured there ought to be no use case for setting up cluster notifications 
with ANYCAST semantics so I added this.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 901524)
    Time Spent: 2.5h  (was: 2h 20m)

> Redistributor race when consumerCount reaches 0 in cluster
> ----------------------------------------------------------
>
>                 Key: ARTEMIS-4527
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4527
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Anton Roskvist
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> This is a very rare bug caused by cluster notifications arriving in the wrong 
> order in some very specific circumstances



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to