[ 
https://issues.apache.org/jira/browse/ARTEMIS-4527?focusedWorklogId=901527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901527
 ]

ASF GitHub Bot logged work on ARTEMIS-4527:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jan/24 19:28
            Start Date: 24/Jan/24 19:28
    Worklog Time Spent: 10m 
      Work Description: AntonRoskvist commented on code in PR #4705:
URL: https://github.com/apache/activemq-artemis/pull/4705#discussion_r1465440403


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/RemoteQueueBindingImpl.java:
##########
@@ -242,7 +243,10 @@ public synchronized void removeConsumer(final SimpleString 
filterString) throws
          }
       }
 
-      consumerCount--;
+      if (--consumerCount < 0) {
+         ActiveMQServerLogger.LOGGER.consumerCountError("Tried to decrement 
consumer count below 0: " + this);

Review Comment:
   It is not strictly necessary no, I can remove it or add some debug logging





Issue Time Tracking
-------------------

    Worklog Id:     (was: 901527)
    Time Spent: 3h  (was: 2h 50m)

> Redistributor race when consumerCount reaches 0 in cluster
> ----------------------------------------------------------
>
>                 Key: ARTEMIS-4527
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4527
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Anton Roskvist
>            Priority: Major
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> This is a very rare bug caused by cluster notifications arriving in the wrong 
> order in some very specific circumstances



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to