[
https://issues.apache.org/jira/browse/ARTEMIS-4651?focusedWorklogId=906490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906490
]
ASF GitHub Bot logged work on ARTEMIS-4651:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/24 16:20
Start Date: 22/Feb/24 16:20
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4827:
URL: https://github.com/apache/activemq-artemis/pull/4827#discussion_r1499518163
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -281,6 +300,15 @@ public void sendMessage(Transaction tx, Message message,
RoutingContext context)
return;
}
+ if (snfQueue.getPagingStore().page(message, tx, pagedRouteContext,
this::copyMessageForPaging)) {
+ return;
+ }
+
+ if (message.isPaged()) {
+ // if the source was paged, we copy the message
+ message = copyMessageForPaging(message);
+ }
Review Comment:
ok. I think the 2 if's should cover that quickly in the comments, its not
obvious now so it definitely wont be later.
Also, thinking....Does any of this changing the ID stuff affect things in
terms of acking later, or what happens when the destination broker is itself
mirroring? E.g I see its setting an 'extra property'.. are those persisted? Or
passed on if the message isnt reencoded? If the broker restarts before the
message gets sent, does that change what the representation of this copied
paged message actually is?
Issue Time Tracking
-------------------
Worklog Id: (was: 906490)
Time Spent: 4h 50m (was: 4h 40m)
> Performance improvements on Mirror and Paging
> ---------------------------------------------
>
> Key: ARTEMIS-4651
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4651
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Before this change, sends were not paged at the SNF. They are now copied.
> I also added a different scheme for retrying messages in a batches. A
> collection with pending IDs is created and a few retries are performed at
> different levels.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
