[
https://issues.apache.org/jira/browse/ARTEMIS-4651?focusedWorklogId=906492&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-906492
]
ASF GitHub Bot logged work on ARTEMIS-4651:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/24 16:41
Start Date: 22/Feb/24 16:41
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4827:
URL: https://github.com/apache/activemq-artemis/pull/4827#discussion_r1499550612
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -281,6 +300,15 @@ public void sendMessage(Transaction tx, Message message,
RoutingContext context)
return;
}
+ if (snfQueue.getPagingStore().page(message, tx, pagedRouteContext,
this::copyMessageForPaging)) {
+ return;
+ }
+
+ if (message.isPaged()) {
+ // if the source was paged, we copy the message
+ message = copyMessageForPaging(message);
+ }
Review Comment:
I had to change the ID providers to return the ID from the broker property
if being set. so.. on that case the ID comes into the right place.
I did a lot of testing to make sure I got this right... a lot of work into
just that part of the acks from a different queue.. it wasn't easy to balance
it out. :)
Issue Time Tracking
-------------------
Worklog Id: (was: 906492)
Time Spent: 5h (was: 4h 50m)
> Performance improvements on Mirror and Paging
> ---------------------------------------------
>
> Key: ARTEMIS-4651
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4651
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Before this change, sends were not paged at the SNF. They are now copied.
> I also added a different scheme for retrying messages in a batches. A
> collection with pending IDs is created and a few retries are performed at
> different levels.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
