[
https://issues.apache.org/jira/browse/ARTEMIS-4648?focusedWorklogId=907555&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-907555
]
ASF GitHub Bot logged work on ARTEMIS-4648:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Feb/24 10:06
Start Date: 29/Feb/24 10:06
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4824:
URL: https://github.com/apache/activemq-artemis/pull/4824#discussion_r1507323452
##########
artemis-cli/src/test/java/org/apache/activemq/cli/test/CliProducerTest.java:
##########
@@ -88,6 +90,124 @@ public void testSendMessage() throws Exception {
checkSentMessages(session, address, null);
}
+ @Test
+ public void testBooleanMessageProperties() throws Exception {
Review Comment:
I'd guess that Clebert was just thinking about it starting X brokers and
making X connections, sessions, producers currently to test something carried
on the message alone that could still be done with 1 of each.
I tend to prefer more granular tests. Although, I'd personally go further
and think the CLI bits could probably have been unit tested without any broker
etc since its just a case of verifying the arg is decoded as expected, and
ensuring things are set as expected on the message before it is sent...the
clients sending of a message with props is covered elsewhere already)
Issue Time Tracking
-------------------
Worklog Id: (was: 907555)
Time Spent: 1h 40m (was: 1.5h)
> Support typed properties on CLI producer
> ----------------------------------------
>
> Key: ARTEMIS-4648
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4648
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
