[
https://issues.apache.org/jira/browse/ARTEMIS-4648?focusedWorklogId=908942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908942
]
ASF GitHub Bot logged work on ARTEMIS-4648:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/24 14:27
Start Date: 08/Mar/24 14:27
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4824:
URL: https://github.com/apache/activemq-artemis/pull/4824#discussion_r1517786516
##########
artemis-cli/src/test/java/org/apache/activemq/cli/test/CliProducerTest.java:
##########
@@ -88,6 +90,124 @@ public void testSendMessage() throws Exception {
checkSentMessages(session, address, null);
}
+ @Test
+ public void testBooleanMessageProperties() throws Exception {
Review Comment:
I pushed another commit that switches the unit tests to be more granular as
with the original tests, and use a mocked message that gets rid of the large
test impl More succinct, and verifies just the ProducerThread behaviour rather
than also testing the test-msg-impl as the prior tests were really doing.
I also restored a basic integration test, since ProducerThreadTest doesnt
really cover that the option is actually entirely wired through correctly and
is effective in practice, and cant really without heavily reworking
Producer+ProducerThread so that a unit test really could verify things from
initial command to the point of 'this message is whats about to be sent'
without still standing up the broker + producer etc.
If you like the changes, just squash them and push...
Issue Time Tracking
-------------------
Worklog Id: (was: 908942)
Time Spent: 2h 50m (was: 2h 40m)
> Support typed properties on CLI producer
> ----------------------------------------
>
> Key: ARTEMIS-4648
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4648
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
