[
https://issues.apache.org/jira/browse/ARTEMIS-4665?focusedWorklogId=907811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-907811
]
ASF GitHub Bot logged work on ARTEMIS-4665:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/24 15:56
Start Date: 01/Mar/24 15:56
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4838:
URL: https://github.com/apache/activemq-artemis/pull/4838#discussion_r1509194240
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPFederationQueuePolicyTest.java:
##########
@@ -2782,6 +2785,8 @@ public void
testPullQueueConsumerBatchCreditTopUpAfterEachBacklogDrain() throws
.now();
}
+ Wait.assertTrue(() ->
server.queueQuery(queueName).getMessageCount() ==
DEFAULT_PULL_CREDIT_BATCH_SIZE);
Review Comment:
@tabish121 ok.. I assumed the test was sending more messages than that.. (I
hadn't fully read the test :) )
I would recommend the timeout though.... but that's optional.. as if I / we
ever move the default method that would be done as part of the whole batch at
the point.
other than that.. it LGTM... merge it whenever you want it. (so I will let
you decide if you are using the timeout or not).
```
Wait.assertTrue(() -> server.queueQuery(queueName).getMessageCount() ==
DEFAULT_PULL_CREDIT_BATCH_SIZE, 5000);
```
Issue Time Tracking
-------------------
Worklog Id: (was: 907811)
Time Spent: 1h 10m (was: 1h)
> Fix intermittent failures in a few AMQP federation tests
> --------------------------------------------------------
>
> Key: ARTEMIS-4665
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4665
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: AMQP
> Affects Versions: 2.32.0
> Reporter: Timothy A. Bish
> Assignee: Timothy A. Bish
> Priority: Minor
> Fix For: 2.33.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Add some additional state checks in the server to server test for AMQP
> federation ensure an address send isn't discarded before the remote receiver
> has attached which is causing some intermittent test failures, also add some
> other state checks to ensure test prerequisites are in place.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
