[
https://issues.apache.org/jira/browse/ARTEMIS-4665?focusedWorklogId=907820&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-907820
]
ASF GitHub Bot logged work on ARTEMIS-4665:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/24 16:11
Start Date: 01/Mar/24 16:11
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4838:
URL: https://github.com/apache/activemq-artemis/pull/4838#discussion_r1509206469
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPFederationQueuePolicyTest.java:
##########
@@ -2782,6 +2785,8 @@ public void
testPullQueueConsumerBatchCreditTopUpAfterEachBacklogDrain() throws
.now();
}
+ Wait.assertTrue(() ->
server.queueQuery(queueName).getMessageCount() ==
DEFAULT_PULL_CREDIT_BATCH_SIZE);
Review Comment:
Setting a different timeout assumes one can guess how slow / fast the CI
machine is which seems tough given the failures I've been seeing. Personally I
tend to be more concerned with the lengthy amount of time it takes to run the
existing tests that do pass rather than the occasional failures due to timeout.
I'd recommend lowering the default timeout value if that is of a major
concern, drop it to 5 or 10 seconds as a baseline.
I've updated the test to set a 10 sec timeout as an arbitrary cutoff.
Issue Time Tracking
-------------------
Worklog Id: (was: 907820)
Time Spent: 1.5h (was: 1h 20m)
> Fix intermittent failures in a few AMQP federation tests
> --------------------------------------------------------
>
> Key: ARTEMIS-4665
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4665
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: AMQP
> Affects Versions: 2.32.0
> Reporter: Timothy A. Bish
> Assignee: Timothy A. Bish
> Priority: Minor
> Fix For: 2.33.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Add some additional state checks in the server to server test for AMQP
> federation ensure an address send isn't discarded before the remote receiver
> has attached which is causing some intermittent test failures, also add some
> other state checks to ensure test prerequisites are in place.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
