[
https://issues.apache.org/jira/browse/ARTEMIS-4668?focusedWorklogId=908397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908397
]
ASF GitHub Bot logged work on ARTEMIS-4668:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/24 18:46
Start Date: 05/Mar/24 18:46
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1513335419
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPLargeMessageWriter.java:
##########
@@ -144,21 +159,28 @@ private void resume() {
private void tryDelivering() {
// This is discounting some bytes due to Transfer payload
- final int frameSize =
protonSender.getSession().getConnection().getTransport().getOutboundFrameSizeLimit()
- 50 - (delivery.getTag() != null ? delivery.getTag().length : 0);
try {
+ if (this.delivery == null) {
+ this.delivery = serverSender.createDelivery(reference, (int)
this.message.getMessageFormat());
+ if (sessionSPI.invokeOutgoing(message,
(ActiveMQProtonRemotingConnection)
sessionSPI.getTransportConnection().getProtocolConnection()) != null) {
+ return;
+ }
Review Comment:
commit to be squashed 55ce243a690a1dcae26587ea6e962effb896f039 is addressing
this
Issue Time Tracking
-------------------
Worklog Id: (was: 908397)
Time Spent: 5.5h (was: 5h 20m)
> Move AMQP Large Message File Handling away from Netty thread
> ------------------------------------------------------------
>
> Key: ARTEMIS-4668
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4668
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.32.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Operations like file.open, file.close, and file.sync should be moved away
> from the Netty Thread for AMQP Large Messages
> This task now is about moving the processing for AMQP Messages. we may in a
> near future also improve tunneled large messages. For now we will do for AMQP
> messages only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
