[
https://issues.apache.org/jira/browse/ARTEMIS-4668?focusedWorklogId=908371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908371
]
ASF GitHub Bot logged work on ARTEMIS-4668:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/24 17:13
Start Date: 05/Mar/24 17:13
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1513187210
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPTunneledCoreLargeMessageReader.java:
##########
@@ -209,13 +208,15 @@ public Message readBytes(Delivery delivery) throws
Exception {
state = State.DONE;
- return result;
- }
+ serverReceiver.onMessageComplete(delivery, result,
deliveryAnnotations);
- return null;
+ close();
Review Comment:
Doesnt feel like a reader should be closing itself. Was meant to be managed
by the interested party using it.
Issue Time Tracking
-------------------
Worklog Id: (was: 908371)
Time Spent: 3h 50m (was: 3h 40m)
> Move AMQP Large Message File Handling away from Netty thread
> ------------------------------------------------------------
>
> Key: ARTEMIS-4668
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4668
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.32.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Operations like file.open, file.close, and file.sync should be moved away
> from the Netty Thread for AMQP Large Messages
> This task now is about moving the processing for AMQP Messages. we may in a
> near future also improve tunneled large messages. For now we will do for AMQP
> messages only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
