[
https://issues.apache.org/jira/browse/AMQ-9460?focusedWorklogId=912440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912440
]
ASF GitHub Bot logged work on AMQ-9460:
---------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/24 09:21
Start Date: 01/Apr/24 09:21
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #1193:
URL: https://github.com/apache/activemq/pull/1193#discussion_r1546140593
##########
assembly/src/release/bin/setenv:
##########
@@ -33,9 +33,7 @@
if [ -z "$ACTIVEMQ_OPTS_MEMORY" ] ; then
ACTIVEMQ_OPTS_MEMORY="-Xms64M -Xmx1G"
fi
-if [ -z "$ACTIVEMQ_OPTS" ] ; then
- ACTIVEMQ_OPTS="$ACTIVEMQ_OPTS_MEMORY
-Djava.util.logging.config.file=logging.properties
-Djava.security.auth.login.config=$ACTIVEMQ_CONF/login.config"
-fi
+ACTIVEMQ_OPTS="$ACTIVEMQ_OPTS_MEMORY $ACTIVEMQ_OPTS
-Djava.util.logging.config.file=logging.properties
-Djava.security.auth.login.config=$ACTIVEMQ_CONF/login.config"
Review Comment:
Seems like this maybe just broke the ability to set your own settings for
these props in ACTIVEMQ_OPTS, since the later ones will take precedence, and it
generally just looks to mess with the behaviour of ACTIVEMQ_OPTS handling.
Given it seems it worked the way it did for 10+ years, that seems a
questionable change in behaviour to aim at a patch release.
This overall change actually seems weird in general as the title is "_Don't
override ACTIVEMQ_OPTS when provided by user_" and yet it looks more like it
mostly does the opposite of that for folks not using Docker, given this
suggests it actually specifically overrides ACTIVEMQ_OPTS provided by the user
and replaces it with its own munged value (that incorporates the users value,
somewhat...but in a way it can still override what they wanted to do...and in a
way that changes it significantly from its historic behaviour of using only
exactly what the user specified, rather than merging it with other config).
Issue Time Tracking
-------------------
Worklog Id: (was: 912440)
Time Spent: 0.5h (was: 20m)
> Running activemq-classic via docker does not allow access to web console
> ------------------------------------------------------------------------
>
> Key: AMQ-9460
> URL: https://issues.apache.org/jira/browse/AMQ-9460
> Project: ActiveMQ Classic
> Issue Type: Bug
> Components: Broker, Docker
> Affects Versions: 6.0.1
> Reporter: Claus Ibsen
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 6.1.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I cannot use the web console when running via docker
> docker run -d -p 61616:61616 -p 8161:8161 apache/activemq-classic
> When you open localhost:8161 the web console comes up, but when you start
> browsing queues then the login page is shown. But admin/admin does not work.
> It works fine in the standalone .tar you can download and run locally.
> It seems the conf/credentials.properties is corrupted in the docker image vs
> standalone.
> Standalone
> {code}
> ~/Downloads/apache-activemq-6.1.0/conf ❯ cat users.properties
> ## ---------------------------------------------------------------------------
> ## Licensed to the Apache Software Foundation (ASF) under one or more
> ## contributor license agreements. See the NOTICE file distributed with
> ## this work for additional information regarding copyright ownership.
> ## The ASF licenses this file to You under the Apache License, Version 2.0
> ## (the "License"); you may not use this file except in compliance with
> ## the License. You may obtain a copy of the License at
> ##
> ## http://www.apache.org/licenses/LICENSE-2.0
> ##
> ## Unless required by applicable law or agreed to in writing, software
> ## distributed under the License is distributed on an "AS IS" BASIS,
> ## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> ## See the License for the specific language governing permissions and
> ## limitations under the License.
> ## ---------------------------------------------------------------------------
> admin=admin%
> {code}
> And on docker:
> {code}
> /opt/apache-activemq/conf
> root@8483a39f7510:/opt/apache-activemq/conf# cat users.properties
> ## ---------------------------------------------------------------------------
> ## Licensed to the Apache Software Foundation (ASF) under one or more
> ## contributor license agreements. See the NOTICE file distributed with
> ## this work for additional information regarding copyright ownership.
> ## The ASF licenses this file to You under the Apache License, Version 2.0
> ## (the "License"); you may not use this file except in compliance with
> ## the License. You may obtain a copy of the License at
> ##
> ## http://www.apache.org/licenses/LICENSE-2.0
> ##
> ## Unless required by applicable law or agreed to in writing, software
> ## distributed under the License is distributed on an "AS IS" BASIS,
> ## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> ## See the License for the specific language governing permissions and
> ## limitations under the License.
> ## ---------------------------------------------------------------------------
> admin=adminroot@8483a39f7510:/opt/apache-activemq/conf#
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
