[
https://issues.apache.org/jira/browse/AMQ-9460?focusedWorklogId=912445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912445
]
ASF GitHub Bot logged work on AMQ-9460:
---------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/24 09:27
Start Date: 01/Apr/24 09:27
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #1193:
URL: https://github.com/apache/activemq/pull/1193#discussion_r1546153836
##########
assembly/src/release/bin/setenv:
##########
@@ -33,9 +33,7 @@
if [ -z "$ACTIVEMQ_OPTS_MEMORY" ] ; then
ACTIVEMQ_OPTS_MEMORY="-Xms64M -Xmx1G"
fi
-if [ -z "$ACTIVEMQ_OPTS" ] ; then
- ACTIVEMQ_OPTS="$ACTIVEMQ_OPTS_MEMORY
-Djava.util.logging.config.file=logging.properties
-Djava.security.auth.login.config=$ACTIVEMQ_CONF/login.config"
-fi
+ACTIVEMQ_OPTS="$ACTIVEMQ_OPTS_MEMORY $ACTIVEMQ_OPTS
-Djava.util.logging.config.file=logging.properties
-Djava.security.auth.login.config=$ACTIVEMQ_CONF/login.config"
Review Comment:
A different change that doesnt alter the long standing existing behaviour or
break anyone, might be to give a more general way of _adding_ options without
needing to define them _all_. E.g adding a new env variable that only appends
to the options stuff rather than define it all, and then using that in the
docker file to pass the additional option. E.g put it back the way it was, and
add a line below here which appends the value of a new variable if set.
Artemis did something similar a while back to allow appending specific
additional args rather than needing to set them all (which worked the same way
as these scripts did before the change...either you specify them all, or the
defaults are used).
Issue Time Tracking
-------------------
Worklog Id: (was: 912445)
Time Spent: 1h (was: 50m)
> Running activemq-classic via docker does not allow access to web console
> ------------------------------------------------------------------------
>
> Key: AMQ-9460
> URL: https://issues.apache.org/jira/browse/AMQ-9460
> Project: ActiveMQ Classic
> Issue Type: Bug
> Components: Broker, Docker
> Affects Versions: 6.0.1
> Reporter: Claus Ibsen
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 6.1.1
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I cannot use the web console when running via docker
> docker run -d -p 61616:61616 -p 8161:8161 apache/activemq-classic
> When you open localhost:8161 the web console comes up, but when you start
> browsing queues then the login page is shown. But admin/admin does not work.
> It works fine in the standalone .tar you can download and run locally.
> It seems the conf/credentials.properties is corrupted in the docker image vs
> standalone.
> Standalone
> {code}
> ~/Downloads/apache-activemq-6.1.0/conf ❯ cat users.properties
> ## ---------------------------------------------------------------------------
> ## Licensed to the Apache Software Foundation (ASF) under one or more
> ## contributor license agreements. See the NOTICE file distributed with
> ## this work for additional information regarding copyright ownership.
> ## The ASF licenses this file to You under the Apache License, Version 2.0
> ## (the "License"); you may not use this file except in compliance with
> ## the License. You may obtain a copy of the License at
> ##
> ## http://www.apache.org/licenses/LICENSE-2.0
> ##
> ## Unless required by applicable law or agreed to in writing, software
> ## distributed under the License is distributed on an "AS IS" BASIS,
> ## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> ## See the License for the specific language governing permissions and
> ## limitations under the License.
> ## ---------------------------------------------------------------------------
> admin=admin%
> {code}
> And on docker:
> {code}
> /opt/apache-activemq/conf
> root@8483a39f7510:/opt/apache-activemq/conf# cat users.properties
> ## ---------------------------------------------------------------------------
> ## Licensed to the Apache Software Foundation (ASF) under one or more
> ## contributor license agreements. See the NOTICE file distributed with
> ## this work for additional information regarding copyright ownership.
> ## The ASF licenses this file to You under the Apache License, Version 2.0
> ## (the "License"); you may not use this file except in compliance with
> ## the License. You may obtain a copy of the License at
> ##
> ## http://www.apache.org/licenses/LICENSE-2.0
> ##
> ## Unless required by applicable law or agreed to in writing, software
> ## distributed under the License is distributed on an "AS IS" BASIS,
> ## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> ## See the License for the specific language governing permissions and
> ## limitations under the License.
> ## ---------------------------------------------------------------------------
> admin=adminroot@8483a39f7510:/opt/apache-activemq/conf#
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
