[
https://issues.apache.org/jira/browse/ARTEMIS-4741?focusedWorklogId=916159&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916159
]
ASF GitHub Bot logged work on ARTEMIS-4741:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/24 10:35
Start Date: 24/Apr/24 10:35
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #4902:
URL:
https://github.com/apache/activemq-artemis/pull/4902#issuecomment-2074641040
I started doing equivalent updates and though the assertNull changes
definitely make sense, its not clear a lot of the assertTrue/assertFalse
changes necessarily do. They are mostly checking Boolean (rather than boolean)
return values, so by changing them to assertTrue/assertFalse they are
potentially just going to throw an NPE before the assertion actually happens.
I'd be inclined to leave those ones as-is.
Issue Time Tracking
-------------------
Worklog Id: (was: 916159)
Time Spent: 40m (was: 0.5h)
> Use specific assertion methods
> ------------------------------
>
> Key: ARTEMIS-4741
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4741
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
