[
https://issues.apache.org/jira/browse/ARTEMIS-4741?focusedWorklogId=916364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-916364
]
ASF GitHub Bot logged work on ARTEMIS-4741:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/24 11:41
Start Date: 25/Apr/24 11:41
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #4902:
URL:
https://github.com/apache/activemq-artemis/pull/4902#issuecomment-2076984557
> I started doing equivalent updates and though the assertNull changes
definitely make sense, its not clear a lot of the assertTrue/assertFalse
changes necessarily do. They are mostly checking Boolean (rather than boolean)
return values, so by changing them to assertTrue/assertFalse they are
potentially just going to throw an NPE before the assertion actually happens.
I'd be inclined to leave those ones as-is.
I went through them all, less were Boolean than it initially seemed. I
converted almost all of them (left the 10 or so where the type wasnt even known
to be Boolean, since the assertEquals handles both the null and the type) and
added assertNotNulls beforehand for the Boolean ones.
In addition to these original changes, also converted an
assertNotEquals(null, foo) into assertNotNull(foo).
Issue Time Tracking
-------------------
Worklog Id: (was: 916364)
Time Spent: 50m (was: 40m)
> Use specific assertion methods
> ------------------------------
>
> Key: ARTEMIS-4741
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4741
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
