[
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922043&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922043
]
ASF GitHub Bot logged work on ARTEMIS-4796:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/24 21:47
Start Date: 04/Jun/24 21:47
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4959:
URL: https://github.com/apache/activemq-artemis/pull/4959#discussion_r1626637601
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java:
##########
@@ -79,6 +96,8 @@ public static SimpleString toSimpleString(final String
string, StringSimpleStrin
public SimpleString(final String string) {
int len = string.length();
+ String.valueOf(1);
Review Comment:
What is this for in this context?
Issue Time Tracking
-------------------
Worklog Id: (was: 922043)
Time Spent: 20m (was: 10m)
> Simplify SimpleString API
> -------------------------
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}}
> implementations. This change would make the code more concise and readable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
