[
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922234
]
ASF GitHub Bot logged work on ARTEMIS-4796:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/24 17:30
Start Date: 05/Jun/24 17:30
Worklog Time Spent: 10m
Work Description: tabish121 commented on PR #4959:
URL:
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2150593808
> > I don't really like the name "of" but that's just my personal taste
probably... (of kind of kicks my OCD.. being a preposition, I feel like of
what? :)
> > but as I said.. that's my personal preference only...
> > but I don't want to get in the way.. I will get used to it :) and I'm +1
to merge it.. and you should probably merge it soon before you have to rebase
it.
> > +1 from me.
>
> I presume it comes from the trend of Map.of(..) etc factory helpers. I
dont mind it, though I personally wouldnt have changed it here given I'd rather
SimpleString vanish, along with all the realted conversions and the byte
doubling etc etc that come with it.
Agreed with Robbie on the name, it matches some Collections APIs etc and
isn't hard to grok plus its just less verbose. But I'd also like to see an
effort towards removing the SimpleString to simplify working with the broker
internals.
Issue Time Tracking
-------------------
Worklog Id: (was: 922234)
Time Spent: 1.5h (was: 1h 20m)
> Simplify SimpleString API
> -------------------------
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}}
> implementations. This change would make the code more concise and readable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
