[
https://issues.apache.org/jira/browse/ARTEMIS-4796?focusedWorklogId=922313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-922313
]
ASF GitHub Bot logged work on ARTEMIS-4796:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/24 10:10
Start Date: 06/Jun/24 10:10
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #4959:
URL:
https://github.com/apache/activemq-artemis/pull/4959#issuecomment-2151907691
The change should probably be rebased to current main, which has already
added new use of the now-deprecated bits that this misses switching over.
From doing a grep, there also looks to remain a number of other existing
uses of toSimpleString that perhaps should be updated also.
Feels like we should be unit testing any otherwise-unused deprecated bits,
but it doesnt appear like either of the two SimpleStringTest classes do so.
Issue Time Tracking
-------------------
Worklog Id: (was: 922313)
Time Spent: 2h 20m (was: 2h 10m)
> Simplify SimpleString API
> -------------------------
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}}
> implementations. This change would make the code more concise and readable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
