[
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=925507&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925507
]
ASF GitHub Bot logged work on ARTEMIS-4809:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/24 17:23
Start Date: 11/Jul/24 17:23
Worklog Time Spent: 10m
Work Description: joshb1050 commented on code in PR #4966:
URL: https://github.com/apache/activemq-artemis/pull/4966#discussion_r1674392684
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1604,6 +1619,7 @@ public void decode(ActiveMQBuffer buffer, boolean
tryCompatible) {
prefetchPageMessages = BufferHelper.readNullableInteger(buffer);
}
+
Review Comment:
Done
##########
docs/user-manual/address-settings.adoc:
##########
@@ -394,6 +394,10 @@ that helps to detect and prevent the processing of
duplicate messages based on t
By default, the `id-cache-size` setting inherits from the global
`id-cache-size`, with a default of `20000`
elements if not explicitly configured. Read more about
xref:duplicate-detection.adoc#configuring-the-duplicate-id-cache[duplicate id
cache sizes].
+intermediate-message-buffer-initial-size::
+defines the initial number of elements of the intermediate message reference
buffer (an `Object[]`), which is instantiated for each queue.
+By default, this value is `8192` bytes if not explicitly configured. This must
be a positive power of 2 (i.e. `0` is not an option).
Review Comment:
Done
Issue Time Tracking
-------------------
Worklog Id: (was: 925507)
Time Spent: 2h (was: 1h 50m)
> Make intermediateMessageReferences initial capacity configurable
> ----------------------------------------------------------------
>
> Key: ARTEMIS-4809
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Reporter: Josh Byster
> Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created
> due to many consumers that are connecting. However, most of these are empty
> and stay empty for the entire day since there aren't necessarily messages to
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer
> ({{Object[]}}). This means we have large allocation and live heap that
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact