[ 
https://issues.apache.org/jira/browse/ARTEMIS-4809?focusedWorklogId=928559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928559
 ]

ASF GitHub Bot logged work on ARTEMIS-4809:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/24 16:20
            Start Date: 02/Aug/24 16:20
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on PR #4966:
URL: 
https://github.com/apache/activemq-artemis/pull/4966#issuecomment-2265739332

   Generally speaking I think this looks good. However, there's a couple of 
things I would revisit:
   
   1. The name `intermediate-message-buffer-initial-size`, while technically 
accurate, is probably not terribly clear to users. I think something like 
`initial-queue-buffer-size` is more clear.
   2. The documentation defines this as the " initial number of elements of the 
intermediate message reference buffer." Again, this is technically accurate, 
but it doesn't give users a clear reason _why_ they might want to configure it. 
The docs should make clear that this is tied directly to the number of _bytes_ 
from the JVM's heap each queue will consume initially. The docs might also 
mention the canonical use-case for this (i.e. lots of queues which might remain 
empty or have a small number of messages).




Issue Time Tracking
-------------------

    Worklog Id:     (was: 928559)
    Time Spent: 2h 50m  (was: 2h 40m)

> Make intermediateMessageReferences initial capacity configurable
> ----------------------------------------------------------------
>
>                 Key: ARTEMIS-4809
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4809
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>            Reporter: Josh Byster
>            Priority: Minor
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> In some setups, there could be a few hundred thousand queues that are created 
> due to many consumers that are connecting. However, most of these are empty 
> and stay empty for the entire day since there aren't necessarily messages to 
> be sent.
> The 8K {{intermediateMessageReferences}} instantiates an 64KB buffer 
> ({{Object[]}}). This means we have large allocation and live heap that 
> ultimately remains empty for almost the entire day.
> It would be quite nice if we could configure this initial size.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to