[
https://issues.apache.org/jira/browse/ARTEMIS-4909?focusedWorklogId=928942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928942
]
ASF GitHub Bot logged work on ARTEMIS-4909:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/24 15:04
Start Date: 06/Aug/24 15:04
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5075:
URL: https://github.com/apache/activemq-artemis/pull/5075#discussion_r1705702940
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
##########
@@ -4689,11 +4689,11 @@ private static void
setUnsetQueueParamsToDefaults(QueueConfiguration c) {
private void deployReloadableConfigFromConfiguration() throws Exception {
if (configurationReloadDeployed.compareAndSet(false, true)) {
- ActiveMQServerLogger.LOGGER.reloadingConfiguration("security");
+
ActiveMQServerLogger.LOGGER.reloadingConfiguration("security-settings");
Review Comment:
I could see making this "security settings", i.e adding " settings" to make
it consistent with the "address settings" one below (which would remain as it
was), but I dont think they should strictly match the XML tags since that may
in fact not be where the configuration is coming from.
Issue Time Tracking
-------------------
Worklog Id: (was: 928942)
Time Spent: 0.5h (was: 20m)
> update category names for "Reloading configuration"
> ---------------------------------------------------
>
> Key: ARTEMIS-4909
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4909
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.35.0
> Reporter: Erwin Dondorp
> Assignee: Erwin Dondorp
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When the broker.xml file is reloaded, the following logfile messages are
> produced:
> {noformat}
> 2024-07-07 20:30:08,138 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: security
> 2024-07-07 20:30:08,140 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: address settings
> 2024-07-07 20:30:08,143 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: diverts
> 2024-07-07 20:30:08,150 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: addresses
> [...]
> 2024-07-07 20:30:08,151 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: bridges
> 2024-07-07 20:30:08,151 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: protocol services
> {noformat}
> in would be more consistent when the actual top-level XML tags are mentioned
> here as these are almost the same.
> and it closer matches the documentation, see
> https://activemq.apache.org/components/artemis/documentation/latest/config-reload.html
> proposing:
> * security --> security-settings
> * address settings --> address-settings
> * diverts (already fine)
> * addresses (already fine)
> * bridges (already fine)
> * protocol services --> this part is not documented in
> https://activemq.apache.org/components/artemis/documentation/latest/config-reload.html,
> let's not touch that now.
> a PR is added.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
