[
https://issues.apache.org/jira/browse/ARTEMIS-4909?focusedWorklogId=928960&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928960
]
ASF GitHub Bot logged work on ARTEMIS-4909:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/24 16:09
Start Date: 06/Aug/24 16:09
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #5075:
URL:
https://github.com/apache/activemq-artemis/pull/5075#issuecomment-2271652156
Some more context here...
The broker currently supports configuration via XML,
[properties](https://activemq.apache.org/components/artemis/documentation/latest/configuration-index.html#broker-properties),
and the management API. JSON support was also [recently
added](https://github.com/apache/activemq-artemis/pull/5120). All of these use
some variant of the words "security," "address," and "settings" together, and I
think it's reasonable for the log to use wording consistent with this. However,
the wording in the log doesn't need to be exactly the same as the XML.
I recommend you keep `address settings` as it is in the log and just change
`security` to `security settings`.
Issue Time Tracking
-------------------
Worklog Id: (was: 928960)
Time Spent: 40m (was: 0.5h)
> update category names for "Reloading configuration"
> ---------------------------------------------------
>
> Key: ARTEMIS-4909
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4909
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.35.0
> Reporter: Erwin Dondorp
> Assignee: Erwin Dondorp
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When the broker.xml file is reloaded, the following logfile messages are
> produced:
> {noformat}
> 2024-07-07 20:30:08,138 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: security
> 2024-07-07 20:30:08,140 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: address settings
> 2024-07-07 20:30:08,143 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: diverts
> 2024-07-07 20:30:08,150 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: addresses
> [...]
> 2024-07-07 20:30:08,151 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: bridges
> 2024-07-07 20:30:08,151 INFO [org.apache.activemq.artemis.core.server]
> AMQ221056: Reloading configuration: protocol services
> {noformat}
> in would be more consistent when the actual top-level XML tags are mentioned
> here as these are almost the same.
> and it closer matches the documentation, see
> https://activemq.apache.org/components/artemis/documentation/latest/config-reload.html
> proposing:
> * security --> security-settings
> * address settings --> address-settings
> * diverts (already fine)
> * addresses (already fine)
> * bridges (already fine)
> * protocol services --> this part is not documented in
> https://activemq.apache.org/components/artemis/documentation/latest/config-reload.html,
> let's not touch that now.
> a PR is added.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
