[
https://issues.apache.org/jira/browse/ARTEMIS-4986?focusedWorklogId=930042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-930042
]
ASF GitHub Bot logged work on ARTEMIS-4986:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/24 13:20
Start Date: 13/Aug/24 13:20
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5145:
URL: https://github.com/apache/activemq-artemis/pull/5145#discussion_r1715281748
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/quorum/QuorumVoteServerConnect.java:
##########
@@ -28,7 +28,12 @@
*/
public class QuorumVoteServerConnect extends QuorumVote<ServerConnectVote,
Boolean> {
+
+ /** NOTE: The following String is used to identify the targetNode
implementation at other servers.
+ * Renaming such string would cause incompatibility changes. */
public static final SimpleString PRIMARY_FAILOVER_VOTE =
SimpleString.of("PrimaryFailoverQuorumVote");
+ public static final SimpleString OLD_PRIMARY_FAILOVER_NOTE =
SimpleString.of("LiveFailoverQuorumVote");
Review Comment:
oops... thanks
Issue Time Tracking
-------------------
Worklog Id: (was: 930042)
Time Spent: 0.5h (was: 20m)
> Replication/Vote incompatibility between 2.30 and 2.31+
> -------------------------------------------------------
>
> Key: ARTEMIS-4986
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4986
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.31.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.37.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The change for "ARTEMIS-3474 replace non-inclusive terms" changed a String
> that was used on the wire for Voting. That string was sent on the Vote and
> the other nodes would fail with the following message:
> AMQ224090: This node is not configured for Quorum Voting, all nodes must be
> configured for HA
> The server will simply not respond the VoteRequest on that case and the
> blockCall timeout will fail.
> To fix this I'm applying a shorter timeout that will just be ignored and
> retry at the older packet in case the response wasn't found.
> I was trying to play with Wire versioning but that scenario turned out to be
> more complex.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
