[
https://issues.apache.org/jira/browse/ARTEMIS-4986?focusedWorklogId=930064&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-930064
]
ASF GitHub Bot logged work on ARTEMIS-4986:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/24 14:48
Start Date: 13/Aug/24 14:48
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5145:
URL: https://github.com/apache/activemq-artemis/pull/5145#discussion_r1715426702
##########
tests/compatibility-tests/pom.xml:
##########
@@ -265,6 +271,58 @@
</plugins>
</build>
<profiles>
+ <profile>
+ <id>compatibility-tests-distribution</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.7.1</version>
Review Comment:
This plugin version is already managed (to 3.7.1) and so should be omitted
##########
tests/compatibility-tests/pom.xml:
##########
@@ -265,6 +271,58 @@
</plugins>
</build>
<profiles>
+ <profile>
+ <id>compatibility-tests-distribution</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.7.1</version>
+ <executions>
+ <execution>
+ <id>unpack-artemis</id>
Review Comment:
perhaps add the version to make the ID unique (here and below)
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/distribution/RollingUpgradeTest.java:
##########
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.compatibility.distribution;
+
+import java.io.File;
+import java.lang.invoke.MethodHandles;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.activemq.artemis.api.core.Pair;
+import org.apache.activemq.artemis.api.core.management.SimpleManagement;
+import org.apache.activemq.artemis.util.ServerUtil;
+import org.apache.activemq.artemis.utils.FileUtil;
+import org.apache.activemq.artemis.utils.SpawnedVMSupport;
+import org.apache.activemq.artemis.utils.Wait;
+import org.apache.activemq.artemis.utils.cli.helper.HelperBase;
+import org.junit.jupiter.api.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
+
+public class RollingUpgradeTest extends CompatBaseTest {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ private static final String TWO_THIRTY =
"./target/old-releases/apache-artemis-2.30.0";
+ private static final String TWO_THIRTY_SIX =
"./target/old-releases/apache-artemis-2.35.0";
Review Comment:
The version in the value needs updated to 2.36.0 as well
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/distribution/CompatBaseTest.java:
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.compatibility.distribution;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.lang.invoke.MethodHandles;
+import java.util.zip.ZipEntry;
+import java.util.zip.ZipInputStream;
+
+import org.apache.activemq.artemis.utils.RealServerTestBase;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class CompatBaseTest extends RealServerTestBase {
Review Comment:
If moving to use dependency::unpack can this be removed?
Issue Time Tracking
-------------------
Worklog Id: (was: 930064)
Time Spent: 2h 10m (was: 2h)
> Replication/Vote incompatibility between 2.30 and 2.31+
> -------------------------------------------------------
>
> Key: ARTEMIS-4986
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4986
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.31.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.37.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The change for "ARTEMIS-3474 replace non-inclusive terms" changed a String
> that was used on the wire for Voting. That string was sent on the Vote and
> the other nodes would fail with the following message:
> AMQ224090: This node is not configured for Quorum Voting, all nodes must be
> configured for HA
> The server will simply not respond the VoteRequest on that case and the
> blockCall timeout will fail.
> To fix this I'm applying a shorter timeout that will just be ignored and
> retry at the older packet in case the response wasn't found.
> I was trying to play with Wire versioning but that scenario turned out to be
> more complex.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
