[
https://issues.apache.org/jira/browse/ARTEMIS-5001?focusedWorklogId=931002&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931002
]
ASF GitHub Bot logged work on ARTEMIS-5001:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/24 16:53
Start Date: 20/Aug/24 16:53
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5158:
URL: https://github.com/apache/activemq-artemis/pull/5158#discussion_r1723650370
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java:
##########
@@ -497,6 +535,20 @@ private boolean sendMessage(Message message,
DeliveryAnnotations deliveryAnnotat
return true;
}
+ @Override
+ public void close(boolean remoteLinkClose) throws ActiveMQAMQPException {
+ super.close(remoteLinkClose);
+
+ if (scheduledRateDebug != null) {
+ try {
+ scheduledRateDebug.cancel(true);
+ } catch (Throwable logOnly) {
+ logger.debug(logOnly.getMessage(), logOnly);
+ }
+ scheduledRateDebug = null;
+ }
Review Comment:
I think the 'log with exception' calls pull the message already...in any
case, maybe add a descriptive string to indicate what is going on.
I think this can possibly be called off the IO thread, in which case the
_scheduledRateDebug_ null check etc could race with the other usage and
nulling. So perhaps it should offload that to the connection thread to ensure
only one is operating?
Issue Time Tracking
-------------------
Worklog Id: (was: 931002)
Time Spent: 0.5h (was: 20m)
> Add configuration option to relax syncs journal replication for Mirror Target
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-5001
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5001
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.37.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When I worked on AMQP Mirror I did not actually envision being used with
> journal replication. I actually thought more about adding multiple mirrored
> options instead.
> However an user reported me that when using mirror and journal replication
> combined, the sends could take a lot longer to happen (some normal latency)
> and the acks would eventually be missed.
> I should add an option to ignore the replication for the Mirror Target.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
