[
https://issues.apache.org/jira/browse/ARTEMIS-5001?focusedWorklogId=931761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931761
]
ASF GitHub Bot logged work on ARTEMIS-5001:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/24 15:55
Start Date: 26/Aug/24 15:55
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5164:
URL: https://github.com/apache/activemq-artemis/pull/5164#discussion_r1731457311
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##########
@@ -48,17 +49,7 @@
public class OperationContextImpl implements OperationContext {
- private boolean syncReplication = true;
-
- @Override
- public void setSyncReplication(boolean syncReplication) {
- this.syncReplication = syncReplication;
- }
-
- @Override
- public boolean isSyncReplication() {
- return syncReplication;
- }
+ private boolean relaxedReplication = true;
Review Comment:
It is not.. this is git-fu... I guess I mixed where I made the changes in
these 3 commits.
Issue Time Tracking
-------------------
Worklog Id: (was: 931761)
Time Spent: 2h 10m (was: 2h)
> Add configuration option to relax syncs journal replication for Mirror Target
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-5001
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5001
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.37.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When I worked on AMQP Mirror I did not actually envision being used with
> journal replication. I actually thought more about adding multiple mirrored
> options instead.
> However an user reported me that when using mirror and journal replication
> combined, the sends could take a lot longer to happen (some normal latency)
> and the acks would eventually be missed.
> I should add an option to ignore the replication for the Mirror Target.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
