[
https://issues.apache.org/jira/browse/ARTEMIS-5001?focusedWorklogId=931780&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931780
]
ASF GitHub Bot logged work on ARTEMIS-5001:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/24 16:40
Start Date: 26/Aug/24 16:40
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5164:
URL: https://github.com/apache/activemq-artemis/pull/5164#discussion_r1731508788
##########
tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/brokerConnection/mirror/ReplicatedBothNodesMirrorTest.java:
##########
@@ -185,20 +188,25 @@ private static void createMirroredServer(String
serverName,
brokerProperties.put("AMQPConnections." + connectionName +
".connectionElements.mirror.sync", "false");
brokerProperties.put("largeMessageSync", "false");
- brokerProperties.put("addressSettings.#.maxSizeMessages", "50");
- brokerProperties.put("addressSettings.#.maxReadPageMessages", "2000");
- brokerProperties.put("addressSettings.#.maxReadPageBytes", "-1");
- brokerProperties.put("addressSettings.#.prefetchPageMessages", "500");
+ brokerProperties.put("mirrorAckManagerQueueAttempts", "5");
+ brokerProperties.put("mirrorAckManagerPageAttempts", "500000");
Review Comment:
Given there is already a boolean indicating the paging/not scenario, I'd
personally go with specific config for the test scenario. It seems unexpected
as-is, I dont even really understand what it is actually going to do.
If not case-specific config, then perhaps an explaining comment why it is
the way it is and what it would do would help, both now and perhaps more
importantly later. Setting this paging related setting which defaults to 2 to
500000 instead when not paging, is not immediately obvious.
Issue Time Tracking
-------------------
Worklog Id: (was: 931780)
Time Spent: 3h 40m (was: 3.5h)
> Add configuration option to relax syncs journal replication for Mirror Target
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-5001
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5001
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.37.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> When I worked on AMQP Mirror I did not actually envision being used with
> journal replication. I actually thought more about adding multiple mirrored
> options instead.
> However an user reported me that when using mirror and journal replication
> combined, the sends could take a lot longer to happen (some normal latency)
> and the acks would eventually be missed.
> I should add an option to ignore the replication for the Mirror Target.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
