[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=933635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-933635
]
ASF GitHub Bot logged work on ARTEMIS-5037:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/24 16:04
Start Date: 06/Sep/24 16:04
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1747364347
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -432,11 +432,29 @@ private void doConnect() {
final boolean coreTunnelingEnabled =
isCoreMessageTunnelingEnabled(replica);
final Symbol[] desiredCapabilities;
- if (coreTunnelingEnabled) {
- desiredCapabilities = new Symbol[]
{AMQPMirrorControllerSource.MIRROR_CAPABILITY,
-
AmqpSupport.CORE_MESSAGE_TUNNELING_SUPPORT};
- } else {
- desiredCapabilities = new Symbol[]
{AMQPMirrorControllerSource.MIRROR_CAPABILITY};
+ if (!replica.isForward()){
Review Comment:
Once you get to this level of complexity to manage the elements in the
desired capabilities I'd suggest just switch to creating an ArrayList and
adding the elements individually based on the configuration and then just doing
a toArray() on that to get the final capabilities array.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/amqpBrokerConnectivity/AMQPMirrorBrokerConnectionElement.java:
##########
@@ -75,6 +77,12 @@ public AMQPMirrorBrokerConnectionElement
setQueueCreation(boolean queueCreation)
return this;
}
+ public boolean isForward () { return forward; }
Review Comment:
I'd rather this use the same formatting as other accessors and not jam it
all on one line, and also space things as others are done here.
Issue Time Tracking
-------------------
Worklog Id: (was: 933635)
Time Spent: 20m (was: 10m)
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-5037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5037
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Thomas Lavocat
> Assignee: Thomas Lavocat
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages:
> if we have a->b-c->a..
> a message will circulate forever in the mirrors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
