[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=934208&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934208
]
ASF GitHub Bot logged work on ARTEMIS-5037:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/24 09:06
Start Date: 11/Sep/24 09:06
Worklog Time Spent: 10m
Work Description: lavocatt commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1753710605
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java:
##########
@@ -264,6 +265,14 @@ public void flow() {
protected void actualDelivery(Message message, Delivery delivery,
DeliveryAnnotations deliveryAnnotations, Receiver receiver, Transaction tx) {
OperationContext oldContext = recoverContext();
incrementSettle();
+ boolean noForward = false;
+ if (receiver.getRemoteDesiredCapabilities() != null) {
+ for (Symbol capability : receiver.getRemoteDesiredCapabilities()) {
+ if (capability == AMQPMirrorControllerSource.NO_FORWARD) {
+ noForward = true;
+ }
+ }
+ }
Review Comment:
That makes a lot of sense. Thanks.
Issue Time Tracking
-------------------
Worklog Id: (was: 934208)
Time Spent: 1h 20m (was: 1h 10m)
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-5037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5037
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Thomas Lavocat
> Assignee: Thomas Lavocat
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages:
> if we have a->b-c->a..
> a message will circulate forever in the mirrors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
