[
https://issues.apache.org/jira/browse/ARTEMIS-5119?focusedWorklogId=941418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-941418
]
ASF GitHub Bot logged work on ARTEMIS-5119:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/24 18:00
Start Date: 01/Nov/24 18:00
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5327:
URL: https://github.com/apache/activemq-artemis/pull/5327#discussion_r1826115570
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -274,7 +274,8 @@ private void
checkIDSupplier(NodeStoreFactory<MessageReference> nodeStoreFactory
private final StorageManager storageManager;
- private volatile AddressSettings addressSettings;
+ // IInstead of looking up the AddressSettings every time, we cache and
monitor it through onChange
Review Comment:
```suggestion
// Instead of looking up the AddressSettings every time, we cache and
monitor it through onChange
```
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -2129,14 +2130,26 @@ public void expire(final MessageReference ref) throws
Exception {
* hence no information about delivering statistics should be
updated. */
@Override
public void expire(final MessageReference ref, final ServerConsumer
consumer, boolean delivering) throws Exception {
- if (addressSettings.getExpiryAddress() != null) {
- createExpiryResources();
+ AddressSettings settingsToUse =
getMessageAddressSettings(ref.getMessage());
Review Comment:
Yeah I wasn't suggesting to combine them as they did seem sufficiently
different on the backend to justify the two methods. Its just the initial bits
were very similar so it would have been nice for them to be set out the same
way for readability.
Combining them seems to have rearranged at least the order of some stuff for
one method, or added some stuff around bindings that other method didnt do
before...I'd need to take a much fuller look to see what I think of those
changes, but I need to finish up just now.
Issue Time Tracking
-------------------
Worklog Id: (was: 941418)
Time Spent: 1h 10m (was: 1h)
> Messages that expire in store-and-forward (sf-) queues should go to original
> queue's configured expiry queue
> ------------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5119
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5119
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.37.0
> Reporter: Rakhi Kumari
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When messages expire in the store-and-forward queues, they go to the
> store-and-forward queue's expiry queue. It would be better if the messages go
> to the original queue's expiry queue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
