[
https://issues.apache.org/jira/browse/ARTEMIS-5119?focusedWorklogId=941437&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-941437
]
ASF GitHub Bot logged work on ARTEMIS-5119:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/24 19:04
Start Date: 01/Nov/24 19:04
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5327:
URL: https://github.com/apache/activemq-artemis/pull/5327#discussion_r1826195555
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -2129,14 +2130,26 @@ public void expire(final MessageReference ref) throws
Exception {
* hence no information about delivering statistics should be
updated. */
@Override
public void expire(final MessageReference ref, final ServerConsumer
consumer, boolean delivering) throws Exception {
- if (addressSettings.getExpiryAddress() != null) {
- createExpiryResources();
+ AddressSettings settingsToUse =
getMessageAddressSettings(ref.getMessage());
Review Comment:
@gemmellr since you mentioned you are looking to review this.. I will leave
this PR open until next week.. no rush about merging this yet.. although it
would be nice before next release.. but it's not happening next week anyways...
so I will leave it open for now.
Issue Time Tracking
-------------------
Worklog Id: (was: 941437)
Time Spent: 1.5h (was: 1h 20m)
> Messages that expire in store-and-forward (sf-) queues should go to original
> queue's configured expiry queue
> ------------------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5119
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5119
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.37.0
> Reporter: Rakhi Kumari
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When messages expire in the store-and-forward queues, they go to the
> store-and-forward queue's expiry queue. It would be better if the messages go
> to the original queue's expiry queue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
