[
https://issues.apache.org/jira/browse/ARTEMIS-5155?focusedWorklogId=944193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944193
]
ASF GitHub Bot logged work on ARTEMIS-5155:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/24 22:46
Start Date: 18/Nov/24 22:46
Worklog Time Spent: 10m
Work Description: tabish121 opened a new pull request, #5355:
URL: https://github.com/apache/activemq-artemis/pull/5355
When the final frame of a large message is being written to the file in the
session thread and an IO error occurs such that that connection is torn down,
the large message reader can be closed before the message is fully processed
resulting in corruption. The large message file close logic needs to occur on
the session thread so that the processing of the bytes can finish and the
message gets added to the Queue and the close can react by not deleting the
file when it runs following the read task.
Issue Time Tracking
-------------------
Worklog Id: (was: 944193)
Time Spent: 1.5h (was: 1h 20m)
> AMQP LargeMessage file can be deleted in error on connection drop if final
> frame is being processed
> ---------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5155
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5155
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.38.0
> Reporter: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This is to fix tests in LargeMessageInterruptTest.
> When sending a large message the file should be closed before calling advance
> and performing further storage operations.
> This is regressed after
> c83ed8957d9d7f06bb29c0fce563fe2e3462993e / ARTEMIS-4668
> Where the file.close was moved to the finalize block after the delivery...
> causing a possible race over a server's failure.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
