[
https://issues.apache.org/jira/browse/ARTEMIS-5155?focusedWorklogId=944361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944361
]
ASF GitHub Bot logged work on ARTEMIS-5155:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/24 14:24
Start Date: 19/Nov/24 14:24
Worklog Time Spent: 10m
Work Description: tabish121 commented on PR #5355:
URL:
https://github.com/apache/activemq-artemis/pull/5355#issuecomment-2485862105
> I think we should still merge #5346
>
> the close of the reader should be done before delivering the message,
regardless.
>
> when I moved the close to finalize I thought it was about closing the
file... as it stands that method should still be called before the
actualDelivery.
Since that change is essentially just a cosmetic change it is orthogonal to
this and can be done if you want but will have no real effect on the underlying
threading race that is occurring here as I've outlined previously.
Issue Time Tracking
-------------------
Worklog Id: (was: 944361)
Time Spent: 2h (was: 1h 50m)
> AMQP LargeMessage file can be deleted in error on connection drop if final
> frame is being processed
> ---------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5155
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5155
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.38.0
> Reporter: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> This is to fix tests in LargeMessageInterruptTest.
> When sending a large message the file should be closed before calling advance
> and performing further storage operations.
> This is regressed after
> c83ed8957d9d7f06bb29c0fce563fe2e3462993e / ARTEMIS-4668
> Where the file.close was moved to the finalize block after the delivery...
> causing a possible race over a server's failure.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
