[
https://issues.apache.org/jira/browse/AMQ-8463?focusedWorklogId=944458&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944458
]
ASF GitHub Bot logged work on AMQ-8463:
---------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/24 19:47
Start Date: 19/Nov/24 19:47
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #1329:
URL: https://github.com/apache/activemq/pull/1329#discussion_r1848970729
##########
activemq-client/src/main/java/org/apache/activemq/management/LongStatistic.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.activemq.management;
+
+/**
+ * A statistic to store a single long value that is not incremented
+ *
+ * Example: Store a timestamp value of a recent message
+ *
+ */
+public interface LongStatistic extends UnsampledStatistic {
Review Comment:
I think it mostly depends on if the different types will have any logic that
is different or needs to be overriden. You could also move common code into an
abstract class if needed, I was just noticing a lot of copy/paste and seemed
like generics could be useful.
Issue Time Tracking
-------------------
Worklog Id: (was: 944458)
Time Spent: 1.5h (was: 1h 20m)
> Add advancedMessageStatistics to destinations
> ---------------------------------------------
>
> Key: AMQ-8463
> URL: https://issues.apache.org/jira/browse/AMQ-8463
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: Broker
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 6.2.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Observability and tracking metrics on the destination can provide current
> message age and indication of message flow activity.
> // Most recent enqueued message info
> enqueuedMessageID
> enqueuedMessageTimestamp
> enqueuedMessageBrokerInTime
> // Most recent dequeued message info
> dequeuedMessageID
> dequeuedMessageTimestamp
> dequeuedMessageBrokerInTime
> // First enqueue since boot
> firstEnqueuedMessageID
> firstEnqueuedMessageTimestamp
> firstEnqueuedMessageBrokerInTime
> // First dequeue since boot
> firstDequeuedMessageID
> firstDequeuedMessageTimestamp
> firstDequeuedMessageBrokerInTime
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
