[
https://issues.apache.org/jira/browse/ARTEMIS-5170?focusedWorklogId=944886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944886
]
ASF GitHub Bot logged work on ARTEMIS-5170:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/24 14:31
Start Date: 21/Nov/24 14:31
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5363:
URL: https://github.com/apache/activemq-artemis/pull/5363#discussion_r1851947858
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/AutoCreateExpiryResourcesTest.java:
##########
@@ -59,6 +59,7 @@ public void setUp() throws Exception {
// set common address settings needed for all tests; make sure to use
getMatch instead of addMatch in invidual tests or these will be overwritten
server.getAddressSettingsRepository().addMatch("#", new
AddressSettings().setAutoCreateExpiryResources(true).setExpiryAddress(expiryAddress).setExpiryDelay(EXPIRY_DELAY));
+
server.getAddressSettingsRepository().addMatch(String.valueOf(expiryAddress),
new AddressSettings().setExpiryDelay(-1L));
Review Comment:
I'm actually curious why it is setting expiry delay on the regular address
settings to begin with, and whether that call should go away instead of adding
this?
Most of the tests look to send messages that have expiration and are
already-expired, so the setting shouldnt affect them after this change.
The exceptions seem to be testAutoCreatedExpiryFilterAnycast /
testAutoCreatedExpiryFilterMulticast that seem to send messages without
expiration. Could it just change to setting one, and then remove the
ExpiryDelay setting here?
Issue Time Tracking
-------------------
Worklog Id: (was: 944886)
Time Spent: 2h (was: 1h 50m)
> Fix AutoCreateExpiryResourcesTest and document expiry of expiry situation
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-5170
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5170
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
