[
https://issues.apache.org/jira/browse/ARTEMIS-5170?focusedWorklogId=944901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944901
]
ASF GitHub Bot logged work on ARTEMIS-5170:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/24 14:50
Start Date: 21/Nov/24 14:50
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5363:
URL: https://github.com/apache/activemq-artemis/pull/5363#discussion_r1852284956
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/AutoCreateExpiryResourcesTest.java:
##########
@@ -59,6 +59,7 @@ public void setUp() throws Exception {
// set common address settings needed for all tests; make sure to use
getMatch instead of addMatch in invidual tests or these will be overwritten
server.getAddressSettingsRepository().addMatch("#", new
AddressSettings().setAutoCreateExpiryResources(true).setExpiryAddress(expiryAddress).setExpiryDelay(EXPIRY_DELAY));
+
server.getAddressSettingsRepository().addMatch(String.valueOf(expiryAddress),
new AddressSettings().setExpiryDelay(-1L));
Review Comment:
other tests are failing in the same situation if I don't set this..
I had added more loops and more sleeps to other tests and they also failed.
I would rather keep this rather to rewrite this test.
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/AutoCreateExpiryResourcesTest.java:
##########
@@ -59,6 +59,7 @@ public void setUp() throws Exception {
// set common address settings needed for all tests; make sure to use
getMatch instead of addMatch in invidual tests or these will be overwritten
server.getAddressSettingsRepository().addMatch("#", new
AddressSettings().setAutoCreateExpiryResources(true).setExpiryAddress(expiryAddress).setExpiryDelay(EXPIRY_DELAY));
+
server.getAddressSettingsRepository().addMatch(String.valueOf(expiryAddress),
new AddressSettings().setExpiryDelay(-1L));
Review Comment:
other tests are failing in the same situation if I don't set this..
I had added more loops and more sleeps to other tests and they also failed.
I would rather keep this rather than rewrite this test.
Issue Time Tracking
-------------------
Worklog Id: (was: 944901)
Time Spent: 2h 10m (was: 2h)
> Fix AutoCreateExpiryResourcesTest and document expiry of expiry situation
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-5170
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5170
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
