[
https://issues.apache.org/jira/browse/ARTEMIS-5202?focusedWorklogId=947341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-947341
]
ASF GitHub Bot logged work on ARTEMIS-5202:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/24 15:34
Start Date: 09/Dec/24 15:34
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5386:
URL: https://github.com/apache/activemq-artemis/pull/5386#discussion_r1876202736
##########
pom.xml:
##########
@@ -79,8 +79,8 @@
<properties>
<maven.compiler.source>11</maven.compiler.source>
- <maven.compiler.target>11</maven.compiler.target>
- <maven.compiler.release>11</maven.compiler.release>
+ <maven.compiler.target>17</maven.compiler.target>
+ <maven.compiler.release>17</maven.compiler.release>
Review Comment:
Ok to hold off to 3.0.0 I guess, though in general I'd just be updating it
at the same time as the others.
Dont forget the other features from 12-16 such as Records etc. (BTW 'Pattern
matching for switch' in 17 was a preview, i.e still cant use without enabling
flag; there was 'expressions in switch' from 14, or 'patterns in instanceof'
from 16).
I think Classic is mainly doing that because changing it causes compile
failures in the existing source. Since we are using maven.compiler.release 17
in this case (meaning it compiles with the 17 signatures regardless), which
classic is not, I'm not sure there is the same scope for compile failure here.
Issue Time Tracking
-------------------
Worklog Id: (was: 947341)
Time Spent: 1.5h (was: 1h 20m)
> Require Java 17+ (i.e drop support for Java 11)
> -----------------------------------------------
>
> Key: ARTEMIS-5202
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5202
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Update relevant {{pom.xml}} files to use Java 17 instead of 11 for building &
> running the code-base.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
